Skip to content

Conversation

Enet4 and others added 20 commits November 18, 2017 16:52
I have this as a Unix-only API since it seems like Windows doesn't have
a similar API.
This makes it more robust when assertions are disabled,
crashing instead of causing UB.

Also introduces a tidy check to enforce this rule,
which in turn necessitated making tidy run on src/rustllvm.

Fixes rust-lang#44020
impl From for Mutex and RwLock

I felt that these implementations were missing, because doing `x.into()` works for other smart containers (such as `RefCell`), and in general I would say that the conversion makes sense.
add doc for doing `Read` from `&str`

This information can be found on [stackoverflow](https://stackoverflow.com/questions/32674905/pass-string-to-function-taking-read-trait) but I think it would be beneficial if it was documented in the `Read` trait itself.

I had an *extremely* hard time finding this information, and "mocking" a reader with a string is an EXTREMELY common thing (I believe).
Add process::parent_id

I have this as a Unix-only API since it seems like Windows doesn't have
a similar API.

r? @alexcrichton
Fixes spelling error in COMPILER_TESTS.md

Fixes a small spelling mistake :P
Fix typo in MIR "cannot move out of borrowed content"

I believe this all we need to change (rust-lang#46018). Anyway, do let me know if there is anything else that needs to changed as well!
Print the address of the pointed value in Pointer impl for Rc and Arc

Fixes rust-lang#35384
[rustllvm] Use report_fatal_error over llvm_unreachable

This makes it more robust when assertions are disabled, crashing instead of causing UB.

Also introduces a tidy check to enforce this rule, which in turn necessitated making tidy run on `src/rustllvm`.

Fixes rust-lang#44020
Fix doc tests for trim_right_matches

First pr, but isn't anything big so hopefully it should all be good.
@rust-highfive
Copy link
Contributor

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm
Copy link
Member Author

kennytm commented Nov 20, 2017

@bors r+ p=9

Huh I thought Homu will repopulate the previous rollup.

@bors
Copy link
Collaborator

bors commented Nov 20, 2017

📌 Commit 079a6e4 has been approved by kennytm

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 20, 2017
@bors
Copy link
Collaborator

bors commented Nov 20, 2017

⌛ Testing commit 079a6e4 with merge 1e44fee...

bors added a commit that referenced this pull request Nov 20, 2017
Rollup of 9 pull requests

- Successful merges: #46082, #46088, #46092, #46107, #46119, #46121, #46122, #46124, #46128
- Failed merges:
@bors
Copy link
Collaborator

bors commented Nov 21, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 1e44fee to master...

@bors bors merged commit 079a6e4 into rust-lang:master Nov 21, 2017
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.